[
https://issues.apache.org/jira/browse/HADOOP-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903164#action_12903164
]
Tsz Wo (Nicholas), SZE commented on HADOOP-6884:
------------------------------------------------
This issue draw up an unbelievably long discussion. Erik's patch is great. Of
course, there is a room for improvement as always, and as many of other
patches. Quite a few people have proposed "better" ideas but only Erik has
provided patches. I have fine with ideas like Doug's or Konstantin's as long
as some one is willing to work on it. IMO, trying to make the logging perfect
is a kind of wasting resources in this community.
Konstantin and I have +1'ed earlier but no one has -1'ed yet. I will commit
Erik's patch 24 hours later if there is no -1.
> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
> Key: HADOOP-6884
> URL: https://issues.apache.org/jira/browse/HADOOP-6884
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Erik Steffl
> Assignee: Erik Steffl
> Fix For: 0.22.0
>
> Attachments: FunAgain.java, FunAgain.java, HADOOP-6884-0.22-1.patch,
> HADOOP-6884-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is
> true, in some cases it's expensive to construct the string that is being
> printed to log. It's much easier to always use LOG.isDebugEnabled() because
> it's easier to check (rather than in each case reason whether it's necessary
> or not).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
