[
https://issues.apache.org/jira/browse/HADOOP-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15160002#comment-15160002
]
Chris Nauroth commented on HADOOP-12535:
----------------------------------------
[~madhuch-ms], thank you for the update. Patch v003 is looking good so far,
and I'm running it through some final tests.
bq. I dont see any reference to SUPPORTS_ATOMIC_RENAME and
SUPPORTS_ATOMIC_DIRECTORY_DELETE defined in ContractOptions.
Oops, you're right. These are unused. Perhaps these flags are just set up for
documentation purposes or anticipating writing atomicity contract tests in the
future. (Cc [[email protected]].) For now, let's take this out of scope for
the current patch and proceed.
bq. testRenameFileBeingAppended is failing.
Yes, if this is a known deviation from HDFS semantics, then using the {{skip}}
method is the right thing to do. I'd appreciate confirmation from
[~dchickabasapa] that this is a difference in semantics and not in fact an
unintended bug in the {{append}} implementation.
bq. Root folder access is not fully supported in WASB. So removed
TestAzureNativeContractRootDir.
Similar question: is this an accepted difference in semantics, or is this a bug
in the handling of /? If it's not certain, then you could create a separate
JIRA to track handling of /. I wouldn't want it to block committing this
patch, because it's clear that we're already getting value from the tests that
are working.
> Run FileSystem contract tests with hadoop-azure.
> ------------------------------------------------
>
> Key: HADOOP-12535
> URL: https://issues.apache.org/jira/browse/HADOOP-12535
> Project: Hadoop Common
> Issue Type: Bug
> Components: azure, test
> Reporter: Chris Nauroth
> Assignee: madhumita chakraborty
> Attachments: HADOOP-12535.001.patch, HADOOP-12535.002.patch,
> HADOOP-12535.003.patch
>
>
> This issue proposes to implement the Hadoop {{FileSystem}} contract tests for
> hadoop-azure/WASB. The contract tests define the expected semantics of the
> {{FileSystem}}, so running these for hadoop-azure is likely to catch
> potential problems and improve overall quality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
