[ 
https://issues.apache.org/jira/browse/HADOOP-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192022#comment-15192022
 ] 

Masatake Iwasaki commented on HADOOP-12672:
-------------------------------------------

{code}
  final public static int getTimeout(Configuration conf) {
    if (!conf.getBoolean(CommonConfigurationKeys.IPC_CLIENT_PING_KEY,
        CommonConfigurationKeys.IPC_CLIENT_PING_DEFAULT)) {
      return getPingInterval(conf);
    }
    return -1;
  }
{code}

{{Client#getTimeout}} returns -1 if ipc.client.ping is true, otherwise returns 
the value of ipc.ping.interval. This seems to reflect the previous behaviour. 
Current client does not time out even if {{ipc.client.ping = false}} because 
{{ConnectionId#ConnectionId}} set pingInterval to 0 in that case. This is 
existing behaviour even before HADOOP-11252.

> RPC timeout should not override IPC ping interval
> -------------------------------------------------
>
>                 Key: HADOOP-12672
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12672
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 2.8.0, 2.7.3, 2.6.4
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>             Fix For: 2.8.0, 2.7.3, 2.6.5
>
>         Attachments: HADOOP-12672.001.patch, HADOOP-12672.002.patch, 
> HADOOP-12672.003.patch, HADOOP-12672.004.patch
>
>
> Currently if the value of ipc.client.rpc-timeout.ms is greater than 0, the 
> timeout overrides the ipc.ping.interval and client will throw exception 
> instead of sending ping when the interval is passed. RPC timeout should work 
> without effectively disabling IPC ping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to