[
https://issues.apache.org/jira/browse/HADOOP-12916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202352#comment-15202352
]
Tsz Wo Nicholas Sze commented on HADOOP-12916:
----------------------------------------------
Thanks [~xyao]. Some comments on the patch.
- In CallQueueManager.createScheduler,
-* createScheduler should be static.
-* Should priorityLevels be passed in the second try-catch?
- Remove public from getPriorityLevel.
- In parseNumLevels, print ns in the warning.
- backOffByResponseTimeEnabled should be declared with a lower case boolean.
- The following are not used. Let's remove them.
-* RpcScheduler.getPriorityLevels()
-* getAverageResponseTime(int level)
-* setScheduler
-* MetricsProxy.numLevels
- DefaultRpcScheduler needs license header.
- averageResponseTimeInLastWindow and callCountInLastWindow need to be
synchronized.
- Let's remove the unused import from Schedulable.
> Allow different Hadoop IPC Call Queue throttling policies with FCQ/BackOff
> --------------------------------------------------------------------------
>
> Key: HADOOP-12916
> URL: https://issues.apache.org/jira/browse/HADOOP-12916
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HADOOP-12916.00.patch
>
>
> Currently back off policy from HADOOP-10597 is hard coded to base on whether
> call queue is full. This ticket is open to allow flexible back off policies
> such as moving average of response time in RPC calls of different priorities.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
