[ 
https://issues.apache.org/jira/browse/HADOOP-12929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199325#comment-15199325
 ] 

Larry McCay commented on HADOOP-12929:
--------------------------------------

The findbugs warning is invalid. It flags a null check as redundant for a value 
that is known to be non-null but that isn't actually true.
It can certainly be null and that is the whole purpose of this patch.

The unit test failure is unrelated to this change.

[~cnauroth] - can I bother you for a review of this, please?

> JWTRedirectAuthenticationHandler must accommodate null expiration time
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-12929
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12929
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>            Reporter: Larry McCay
>            Assignee: Larry McCay
>         Attachments: HADOOP-12929-001.patch
>
>
> The underlying JWT token within the hadoop-jwt cookie should be able to have 
> no expiration time. This allows the token lifecycle to be the same as the 
> cookie that contains it.
> Current validation processing of the token interprets the absence of an 
> expiration time as requiring a new token to be acquired. JWT itself considers 
> the exp to be an optional claim. As such, this patch will change the 
> processing to accept a null expiration as valid for as long as the cookie is 
> presented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to