[
https://issues.apache.org/jira/browse/HADOOP-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214317#comment-15214317
]
Tony Wu commented on HADOOP-12875:
----------------------------------
Hi [~vishwajeet.dusane],
Thanks a lot for filing a separate JIRA, isolating out the ADL unit tests and
providing a FS contract test! This is very helpful.
I did a quick scan of the patch and have the following comments regarding the
newly added FS contract tests:
Instead of having the following change in various contract test implementations:
{code:java}
+ @Override
+ protected boolean isSupported(String feature) throws IOException {
+ return true;
+ }
{code}
It's better to define a {{adls.xml}} file where you specify the file system
behavior. You can refer to {{wasb.xml}} as an example. This page
[here|https://hadoop.apache.org/docs/r2.7.2/hadoop-project-dist/hadoop-common/filesystem/testing.html]
also describes the details of FS contract tests and best practices of adding
new ones.
Instead of adding {{@Ignore}} to test cases unsupported by ADL, I believe you
can use {{ContractTestUtils#unsupported("...")}} or
{{ContractTestUtils#unsupported("skip")}} instead.
> [Azure Data Lake] Support for contract test and unit test cases
> ---------------------------------------------------------------
>
> Key: HADOOP-12875
> URL: https://issues.apache.org/jira/browse/HADOOP-12875
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, fs/azure, tools
> Reporter: Vishwajeet Dusane
> Assignee: Vishwajeet Dusane
> Attachments: Hadoop-12875-001.patch
>
>
> This JIRA describes contract test and unit test cases support for azure data
> lake file system.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
