[
https://issues.apache.org/jira/browse/HADOOP-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214972#comment-15214972
]
Andrew Wang commented on HADOOP-12701:
--------------------------------------
This change seems fine, I'm not too worried about adding 10s of seconds to
checkstyle runs.
However, why aren't we seeing checkstyle run by precommit? Do we need to add a
space to a java file somewhere to trigger change detection?
> Run checkstyle on test source files
> -----------------------------------
>
> Key: HADOOP-12701
> URL: https://issues.apache.org/jira/browse/HADOOP-12701
> Project: Hadoop Common
> Issue Type: Test
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HADOOP-12701.001.patch
>
>
> Test source files are not checked by checkstyle because Maven checkstyle
> plugin parameter *includeTestSourceDirectory* is *false* by default.
> Propose to enable checkstyle on test source files in order to improve the
> quality of unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
