[
https://issues.apache.org/jira/browse/HADOOP-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218699#comment-15218699
]
Xiaoyu Yao commented on HADOOP-12950:
-------------------------------------
[~jingzhao], the SortedSet/SortedMap uses the overwritten Comparator (based on
Priority order not the hash of the Runnable) as an optimization (binary vs
linear) to search for the hook upon ShutdownHookManger#hasShutdownHook and
ShutdownHookManager#removeShutdownHook. I plan to change back to the HashSet
without overwite the Comparator and returns a separate sorted list, what do you
think?
> ShutdownHookManager should have a timeout for each of the Registered shutdown
> hook
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-12950
> URL: https://issues.apache.org/jira/browse/HADOOP-12950
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HADOOP-12950.00.patch, HADOOP-12950.01.patch,
> HADOOP-12950.02.patch
>
>
> HADOOP-8325 added a ShutdownHookManager to be used by different components
> instead of the JVM shutdownhook. For each of the shutdown hook registered, we
> currently don't have an upper bound for its execution time. We have seen
> namenode failed to shutdown completely (waiting for shutdown hook to finish
> after failover) for a long period of time, which breaks the namenode high
> availability scenarios. This ticket is opened to allow specifying a timeout
> value for the registered shutdown hook.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
