[
https://issues.apache.org/jira/browse/HADOOP-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218785#comment-15218785
]
Gary Helmling commented on HADOOP-12973:
----------------------------------------
In {{getInstance()}}, when invoking the configured class constructor, I think
it would be good to log a message in case one of the possible exceptions is
thrown. Otherwise there's no feedback to the user that the expected
configuration failed. Otherwise, this looks good.
Agreed that the exception handling is wonky. Logging a warn on run failures
seems better, but it would still be good to have a way for callers to
differentiate the states of actually 0 used vs. a failure to run.
> make DU pluggable
> -----------------
>
> Key: HADOOP-12973
> URL: https://issues.apache.org/jira/browse/HADOOP-12973
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HADOOP-12973v0.patch, HADOOP-12973v1.patch,
> HADOOP-12973v2.patch, HADOOP-12973v3.patch, HADOOP-12973v5.patch,
> HADOOP-12973v6.patch
>
>
> If people are concerned about replacing the call to DU. Then an easy first
> step is to make it pluggable. Then it's possible to replace it with something
> while leaving the default alone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
