[
https://issues.apache.org/jira/browse/HADOOP-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218979#comment-15218979
]
John Zhuge commented on HADOOP-12972:
-------------------------------------
Hi [~cmccabe],
Agree with you on that the library version should be printed since we only
bundles the library code, thus ok with your patch.
{{programs/lz4cli.c}} is in {{github.com:Cyan4973/lz4.git}}. In order to
correlate Hadoop lz4 library with OS lz4 command, things get a little messy
because there are actually 3 "versions": git tag, cli version, and library
version. Here is a table of these 3 columns from
{{github.com:Cyan4973/lz4.git}}:
{code}
$ lz4vers
tag cliver libver
lz4-r130 r128 1.7.0
r116 v1.1.5 1.1.3
r117 v1.1.5 1.1.3
r118 v1.2.0 1.2.0
r119 v1.2.0 1.2.0
r120 v1.2.0 1.3.0
r121 v1.2.0 1.3.0
r122 r122 1.3.0
r123 r122 1.3.1
r124 r122 1.4.0
r125 r125 1.4.1
r126 r126 1.5.0
r127 r126 1.5.0
r128 r128 1.6.0
r129 r128 1.7.0
r130 r128 1.7.0
r131 r128 1.7.1
rc129v0 r128 1.7.0
{code}
This seems to be the rules of versioning: cli and lib versions can be bumped
independently; if one of them is bumped, tag is bumped; if neither of them is
bumped, tag may still be bumped.
IMO, the correct fix is for {{lz4 -h}} to display lib version in addition to
cli version. Created https://github.com/Cyan4973/lz4/issues/192.
> Lz4Compressor#getLibraryName returns the wrong version number
> -------------------------------------------------------------
>
> Key: HADOOP-12972
> URL: https://issues.apache.org/jira/browse/HADOOP-12972
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.6.0
> Reporter: John Zhuge
> Assignee: Colin Patrick McCabe
> Priority: Trivial
> Fix For: 2.8.0
>
> Attachments: HADOOP-12972.001.patch
>
>
> HADOOP-11184 updated lz4 to "r123", but {{hadoop checknative -a}} still
> prints "revision:99".
> {code}
> $ hadoop checknative -a
> 16/03/29 11:42:40 INFO bzip2.Bzip2Factory: Successfully loaded & initialized
> native-bzip2 library system-native
> 16/03/29 11:42:40 INFO zlib.ZlibFactory: Successfully loaded & initialized
> native-zlib library
> Native library checking:
> hadoop: true
> /opt/cloudera/parcels/CDH-5.8.0-1.cdh5.8.0.p0.1209/lib/hadoop/lib/native/libhadoop.so.1.0.0
> zlib: true /lib64/libz.so.1
> snappy: true
> /opt/cloudera/parcels/CDH-5.8.0-1.cdh5.8.0.p0.1209/lib/hadoop/lib/native/libsnappy.so.1
> lz4: true revision:99
> bzip2: true /lib64/libbz2.so.1
> openssl: true /usr/lib64/libcrypto.so
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
