[
https://issues.apache.org/jira/browse/HADOOP-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223744#comment-15223744
]
ASF GitHub Bot commented on HADOOP-12984:
-----------------------------------------
Github user aajisaka commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/89#discussion_r58334727
--- Diff:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
---
@@ -87,7 +87,7 @@ public static void setUp() throws Exception {
// Set up the hosts/exclude files.
localFileSys = FileSystem.getLocal(conf);
Path workingDir = localFileSys.getWorkingDirectory();
- dir = new Path(workingDir, "build/test/data/work-dir/decommission");
+ dir = new Path(workingDir, "target/test/data" +
"work-dir/decommission");
--- End diff --
I'm thinking the string concatenation by `+` is unnecessarily.
> Add GenericTestUtils.getTestDir method and use it for temporary directory in
> tests
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-12984
> URL: https://issues.apache.org/jira/browse/HADOOP-12984
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Affects Versions: 3.0.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-12984-003.patch, HDFS-9263-001.patch,
> HDFS-9263-002.patch, HDFS-9263-003.patch
>
>
> We have seen some tests had been used the path {{test/build/data}} to store
> files, so leaking files which fail the new post-build RAT test checks on
> Jenkins (and dirtying all development systems with paths which {{mvn clean}}
> will miss.
> In order not to occur these bugs such as MAPREDUCE-6589 and HDFS-9571 again,
> we'd like to introduce new utility methods to get a temporary directory path
> easily, and use the methods in tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
