[
https://issues.apache.org/jira/browse/HADOOP-6956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910650#action_12910650
]
Konstantin Boudnik commented on HADOOP-6956:
--------------------------------------------
I might have missed something but system tests related code is taken care off
by a separate target, namely {{inject-system-faults}}. Common's build produces
two types of artifacts: normal jar files and instrumented one. The latter is
created when {{jar-system}} is executed. Both kinds of jars are then can be
published to Maven and used by upstream projects.
In MR (or HDFS), when one runs {{inject-system-faults}} or other related
targets Ivy system will pull down proper Common's instrumented jars from Maven
and use them.
{{src/test/system}} contains not only system (cluster) tests but also the
framework to execute those. It might be a little bit confusing at the beggining.
In other words, I don't think your patch is needed.
> compile-core-test
> -----------------
>
> Key: HADOOP-6956
> URL: https://issues.apache.org/jira/browse/HADOOP-6956
> Project: Hadoop Common
> Issue Type: Task
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vivek Mishra
> Fix For: 0.22.0
>
> Attachments: Hadoop-6956.patch
>
>
> Currently compile-core-test only compiles test/core classes. classes defined
> in test/system are required by Mapreduce project's test classes. It requires
> to make a minor change in common build.xml as given below:
> Changed
> <javac
> encoding="${build.encoding}"
> srcdir="${test.src.dir}"
> includes="**/org/apache/hadoop/**/*.java"
> destdir="${test.core.build.classes}"
> debug="${javac.debug}"
> optimize="${javac.optimize}"
> target="${javac.version}"
> source="${javac.version}"
> deprecation="${javac.deprecation}">
> <compilerarg line="${javac.args} ${javac.args.warnings}" />
> <classpath refid="test.classpath"/>
> </javac>
> Original:
> <javac
> encoding="${build.encoding}"
> srcdir="${test.src.dir}/core"
> includes="org/apache/hadoop/**/*.java"
> destdir="${test.core.build.classes}"
> debug="${javac.debug}"
> optimize="${javac.optimize}"
> target="${javac.version}"
> source="${javac.version}"
> deprecation="${javac.deprecation}">
> <compilerarg line="${javac.args} ${javac.args.warnings}" />
> <classpath refid="test.classpath"/>
> </javac>
> change is to
> srcdir="${test.src.dir}"
> includes="**/org/apache/hadoop/**/*.java"
> from original
> srcdir="${test.src.dir}/core"
> includes="org/apache/hadoop/**/*.java"
> Please suggest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
