[
https://issues.apache.org/jira/browse/HADOOP-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246913#comment-15246913
]
Colin Patrick McCabe commented on HADOOP-13010:
-----------------------------------------------
bq. Yeah, it's good to document this stateless property in JavaDoc. Note by the
way it doesn't mean these encoder/decoder are to support concurrency though
it's possible. I would leave this for future consideration.
Sure. In that case, we should document that these objects are not guaranteed
to be thread-safe, so that there is no confusion.
bq. Ah yes the names (EncoderState/DecoderState) are bad, actually I meant them
to be EncodingState/DecodingState.
OK.
bq. Ok, I'm probably convinced by you. Thanks for the lots of insights. I got
rid of the base class anyway, and introduced ErasureCoderConf for the variables
and methods in it. As you might check the updated patch, there are some
duplicate of small shortcuts between the encoder base class and decoder base
class as they now lack a common base. I suppose it's acceptable.
Great.
> Refactor raw erasure coders
> ---------------------------
>
> Key: HADOOP-13010
> URL: https://issues.apache.org/jira/browse/HADOOP-13010
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Fix For: 3.0.0
>
> Attachments: HADOOP-13010-v1.patch, HADOOP-13010-v2.patch,
> HADOOP-13010-v3.patch
>
>
> This will refactor raw erasure coders according to some comments received so
> far.
> * As discussed in HADOOP-11540 and suggested by [~cmccabe], better not to
> rely class inheritance to reuse the codes, instead they can be moved to some
> utility.
> * Suggested by [~jingzhao] somewhere quite some time ago, better to have a
> state holder to keep some checking results for later reuse during an
> encode/decode call.
> This would not get rid of some inheritance levels as doing so isn't clear yet
> for the moment and also incurs big impact. I do wish the end result by this
> refactoring will make all the levels more clear and easier to follow.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
