[ 
https://issues.apache.org/jira/browse/HADOOP-13018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253598#comment-15253598
 ] 

Steve Loughran commented on HADOOP-13018:
-----------------------------------------

# you can use {{verifyFileIsValid}} is to validate the existence/file-ness of 
the token file; it will return true if the code should carry on on with the 
validation
# if there is problems with the file, should the validation just log or exit? 
The {{verify()}} method makes that decision for conditions; there isn't an 
equivalent for exception catch & rethrow ... this might be time. to add that.

I know that the UGI stuff should now fail meaningfully if there are problems 
with the token file ... if we are confident that this holds then maybe your 
policy: log-but-continue is the right one.

Testing: how about setting things up with an invalid path to the token file and 
see how kdiag reacts?



> Make Kdiag check whether hadoop.token.files points to existent and valid files
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-13018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13018
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>         Attachments: HADOOP-13018.01.patch
>
>
> Steve proposed that KDiag should fail fast to help debug the case that 
> hadoop.token.files points to a file not found. This JIRA is to affect that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to