[ 
https://issues.apache.org/jira/browse/HADOOP-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259373#comment-15259373
 ] 

Andrew Wang commented on HADOOP-12892:
--------------------------------------

Thanks for the rev Allen, LGTM +1. Tested locally and seems to have worked. I 
see you chose not to do some of the option validations I recommended, but 
that's a matter of taste.

Only nit is that there's an extra space in --asfrelease usage text. Minor 
enough that we can fix on at commit time? IDK if you have anything else 
feature-wise you want to add.

> fix/rewrite create-release
> --------------------------
>
>                 Key: HADOOP-12892
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12892
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>         Attachments: HADOOP-12892.00.patch, HADOOP-12892.01.patch, 
> HADOOP-12892.02.patch, HADOOP-12892.03.patch
>
>
> create-release needs some major surgery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to