[
https://issues.apache.org/jira/browse/HADOOP-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260128#comment-15260128
]
Hadoop QA commented on HADOOP-13028:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 5m 6s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
24s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 2s
{color} | {color:green} trunk passed with JDK v1.8.0_92 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 36s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
10s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 21s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
40s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
10s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s
{color} | {color:green} trunk passed with JDK v1.8.0_92 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 17s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 53s
{color} | {color:green} the patch passed with JDK v1.8.0_92 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 53s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 40s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 40s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 5s
{color} | {color:red} root: The patch generated 34 new + 55 unchanged - 2 fixed
= 89 total (was 57) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 14s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
24s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 44s
{color} | {color:red} hadoop-tools/hadoop-aws generated 15 new + 0 unchanged -
0 fixed = 15 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 12s
{color} | {color:red} hadoop-aws in the patch failed with JDK v1.8.0_92.
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 15s
{color} | {color:red} hadoop-tools_hadoop-aws-jdk1.7.0_95 with JDK v1.7.0_95
generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 39s
{color} | {color:green} hadoop-common in the patch passed with JDK v1.8.0_92.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 12s
{color} | {color:green} hadoop-aws in the patch passed with JDK v1.8.0_92.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 50s
{color} | {color:green} hadoop-common in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 14s
{color} | {color:green} hadoop-aws in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 73m 57s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-tools/hadoop-aws |
| | org.apache.hadoop.fs.s3.INode.getBlocks() may expose internal
representation by returning INode.blocks At INode.java:by returning
INode.blocks At INode.java:[line 63] |
| | new org.apache.hadoop.fs.s3.INode(INode$FileType, Block[]) may expose
internal representation by storing an externally mutable object into
INode.blocks At INode.java:internal representation by storing an externally
mutable object into INode.blocks At INode.java:[line 59] |
| | org.apache.hadoop.fs.s3.INode.FILE_TYPES should be package protected At
INode.java: At INode.java:[line 44] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readExceptions
in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readException()
At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readException()
At S3AInstrumentation.java:[line 360] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readFullyOperations
in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readFullyOperationStarted(long,
long) At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readFullyOperationStarted(long,
long) At S3AInstrumentation.java:[line 390] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readsIncomplete
in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readOperationCompleted(int,
int) At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readOperationCompleted(int,
int) At S3AInstrumentation.java:[line 400] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readOperations
in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readOperationStarted(long,
long) At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.readOperationStarted(long,
long) At S3AInstrumentation.java:[line 380] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.backwardSeekOperations
in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekBackwards(long)
At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekBackwards(long)
At S3AInstrumentation.java:[line 318] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekOperations
in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekBackwards(long)
At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekBackwards(long)
At S3AInstrumentation.java:[line 317] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.forwardSeekOperations
in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekForwards(long)
At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekForwards(long)
At S3AInstrumentation.java:[line 329] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekOperations
in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekForwards(long)
At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.seekForwards(long)
At S3AInstrumentation.java:[line 328] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.aborted in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean)
At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean)
At S3AInstrumentation.java:[line 350] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.closeOperations
in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean)
At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean)
At S3AInstrumentation.java:[line 348] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.closed in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean)
At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamClose(boolean)
At S3AInstrumentation.java:[line 352] |
| | Increment of volatile field
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.openOperations
in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamOpened()
At S3AInstrumentation.java:in
org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatistics.streamOpened()
At S3AInstrumentation.java:[line 339] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:fbe3e86 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12800994/HADOOP-13028-006.patch
|
| JIRA Issue | HADOOP-13028 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle xml |
| uname | Linux 60fec12107ab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 66b07d8 |
| Default Java | 1.7.0_95 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_92
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9193/artifact/patchprocess/diff-checkstyle-root.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9193/artifact/patchprocess/whitespace-eol.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9193/artifact/patchprocess/new-findbugs-hadoop-tools_hadoop-aws.html
|
| javadoc |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9193/artifact/patchprocess/patch-javadoc-hadoop-tools_hadoop-aws-jdk1.8.0_92.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9193/artifact/patchprocess/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdk1.7.0_95.txt
|
| JDK v1.7.0_95 Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9193/testReport/ |
| modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9193/console |
| Powered by | Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> add low level counter metrics for S3A; use in read performance tests
> --------------------------------------------------------------------
>
> Key: HADOOP-13028
> URL: https://issues.apache.org/jira/browse/HADOOP-13028
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, metrics
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-13028-001.patch, HADOOP-13028-002.patch,
> HADOOP-13028-004.patch, HADOOP-13028-005.patch, HADOOP-13028-006.patch,
> org.apache.hadoop.fs.s3a.scale.TestS3AInputStreamPerformance-output.txt,
> org.apache.hadoop.fs.s3a.scale.TestS3AInputStreamPerformance-output.txt
>
>
> against S3 (and other object stores), opening connections can be expensive,
> closing connections may be expensive (a sign of a regression).
> S3A FS and individual input streams should have counters of the # of
> open/close/failure+reconnect operations, timers of how long things take. This
> can be used downstream to measure efficiency of the code (how often
> connections are being made), connection reliability, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
