[ 
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262497#comment-15262497
 ] 

Masatake Iwasaki commented on HADOOP-12101:
-------------------------------------------

The patch affects TestHdfsConfigFields, TestYarnConfigurationFields and 
TestMapreduceConfigFields but QA build does not run them since the patch only 
changes the codes under hadoop-common. I ran TestHdfsConfigFields, 
TestYarnConfigurationFields and TestMapreduceConfigFields locally and verified 
that it works.

I think it is ok to handle values with units and variable expantion in 
follow-up JIRAs.

{noformat}
  XML Property: dfs.namenode.lifeline.handler.ratio
  XML Value:    0.10
  Config Name:  DFS_NAMENODE_LIFELINE_HANDLER_RATIO_DEFAULT
  Config Value: 0.1

  XML Property: dfs.namenode.retrycache.heap.percent
  XML Value:    0.03f
  Config Name:  DFS_NAMENODE_RETRY_CACHE_HEAP_PERCENT_DEFAULT
  Config Value: 0.03

  XML Property: dfs.namenode.edits.dir
  XML Value:    ${dfs.namenode.name.dir}
  Config Name:  DFS_NAMENODE_EDITS_DIR_DEFAULT
  Config Value: file:///tmp/hadoop/dfs/name

  XML Property: dfs.datanode.balance.bandwidthPerSec
  XML Value:    10m
  Config Name:  DFS_DATANODE_BALANCE_BANDWIDTHPERSEC_DEFAULT
  Config Value: 10485760
{noformat}


> Add automatic search of default Configuration variables to 
> TestConfigurationFieldsBase
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12101
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12101
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.7.0
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>              Labels: supportability
>         Attachments: HADOOP-12101.001.patch, HADOOP-12101.002.patch, 
> HADOOP-12101.003.patch, HADOOP-12101.004.patch, HADOOP-12101.005.patch, 
> HADOOP-12101.006.patch, HADOOP-12101.007.patch, HADOOP-12101.008.patch, 
> HADOOP-12101.009.patch, HADOOP-12101.010.patch, HADOOP-12101.011.patch, 
> HADOOP-12101.012.patch
>
>
> Add functionality given a Configuration variable FOO, to at least check the 
> xml file value against DEFAULT_FOO.
> Without waivers and a mapping for exceptions, this can probably never be a 
> test method that generates actual errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to