[ 
https://issues.apache.org/jira/browse/HADOOP-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiao Chen updated HADOOP-13077:
-------------------------------
    Attachment: HADOOP-13077.02.patch

Thanks [~aw] for the detailed reviews!

Patch 2 addresses most of your comments. The only difference is that I 
extracted 2 functions, to escape sed and xml separately. They could be of 
general use. :)

I manually verified the scripts work by just executing the scripts with correct 
env vars. (Didn't find any example in our code or the 
[docs|https://wiki.apache.org/hadoop/UnixShellScriptProgrammingGuide] about how 
shell unit tests are done in hadoop... Please feel free to share your thoughts)

> Handle special characters in passwords in httpfs.sh
> ---------------------------------------------------
>
>                 Key: HADOOP-13077
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13077
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-13077-repro.tar.gz, HADOOP-13077.01.patch, 
> HADOOP-13077.02.patch
>
>
> As [~aw] pointed out in [this 
> comment|https://issues.apache.org/jira/browse/HADOOP-13030?focusedCommentId=15262439&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15262439],
>  need a similar fix to this script.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to