[
https://issues.apache.org/jira/browse/HADOOP-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265940#comment-15265940
]
Tsz Wo Nicholas Sze commented on HADOOP-12957:
----------------------------------------------
{quote}
The previous format string is fine, but FindBugs just mistakingly thinks '%d\n'
as '%n'. Patch v010 is posted to have the change:
{code}
String errMsg = String.format(
"Exceeded limit of max asynchronous calls: %d, " +
"please configure %s to adjust it.",
CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_DEFAULT,
CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_KEY);
{code}
{quote}
The findbugs warning indeed says that we should use "%n" and avoid using "\n"
since "%n" is the platform-specific line separator; see
http://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html . Anyway,
removing it is good.
BTW, we should print out the configured value but not the default value, i.e.
CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_DEFAULT should be replaced
by maxAsyncCalls.
> Limit the number of outstanding async calls
> -------------------------------------------
>
> Key: HADOOP-12957
> URL: https://issues.apache.org/jira/browse/HADOOP-12957
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HADOOP-12957-HADOOP-12909.000.patch,
> HADOOP-12957-combo.000.patch, HADOOP-12957.001.patch, HADOOP-12957.002.patch,
> HADOOP-12957.003.patch, HADOOP-12957.004.patch, HADOOP-12957.005.patch,
> HADOOP-12957.006.patch, HADOOP-12957.007.patch, HADOOP-12957.008.patch,
> HADOOP-12957.009.patch, HADOOP-12957.010.patch
>
>
> In async RPC, if the callers don't read replies fast enough, the buffer
> storing replies could be used up. This is to propose limiting the number of
> outstanding async calls to eliminate the issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
