[ 
https://issues.apache.org/jira/browse/HADOOP-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267385#comment-15267385
 ] 

Arpit Agarwal edited comment on HADOOP-13068 at 5/2/16 8:02 PM:
----------------------------------------------------------------

Hi [~boky01], _hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml_ 
is correct. IIUC checkstyle only flags new issues introduced by your patch.

The RunJar's package directory has package.html. You see a warning in your run 
because checkstyle.xml is not configured to allow it. See 
http://checkstyle.sourceforge.net/config_javadoc.html#JavadocPackage.

I think you can just ignore this error, we use package.html all over the place.


was (Author: arpitagarwal):
Hi [~boky01], that is the correct 
_hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml_. IIUC 
checkstyle only flags new issues introduced by your patch.

The RunJar's package directory has package.html. You see a warning in your run 
because checkstyle.xml is not configured to allow it. See 
http://checkstyle.sourceforge.net/config_javadoc.html#JavadocPackage.

I think you can just ignore this error, we use package.html all over the place.

> Clean up RunJar and related test class
> --------------------------------------
>
>                 Key: HADOOP-13068
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13068
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 2.7.2
>            Reporter: Andras Bokor
>            Assignee: Andras Bokor
>            Priority: Trivial
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-13068.01.patch, HADOOP-13068.02.patch, 
> HADOOP-13068.03.patch
>
>
> Clean up RunJar and related test class to remove IDE and checkstyle warnings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to