[ 
https://issues.apache.org/jira/browse/HADOOP-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915604#action_12915604
 ] 

Devaraj Das commented on HADOOP-6965:
-------------------------------------

Some comments:
1) Seems like you copy-pasted the 0.20 version of getTGT (from your patch on 
HDFS-1364). The trunk version in the ticket renewal thread is slightly 
different.
2) Let's bite the bullet and remove the check for hasSufficientTimeElapsed in 
the reloginFromKeytab method. We may do the same for reloginFromTicketCache in 
a follow-up jira.
3) The testcase can be removed. I don't think it is adding value. If it can be 
improved, fine (i understand its hard to write a unit test for this without a 
Kerberos test infrastructure).. otherwise a note on manual testing should be 
sufficient.

> Method in UGI to get Kerberos ticket. 
> --------------------------------------
>
>                 Key: HADOOP-6965
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6965
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>         Attachments: HADOOP-6965.1.patch, HADOOP-6965.3.patch
>
>
> The getTGT method in AutoRenewal thread is moved to the outer UGI class. It 
> is still a private method but can be used by reloginFromKeyTab to check for 
> TGT expiry. This jira covers common changes for HDFS-1364

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to