[ 
https://issues.apache.org/jira/browse/HADOOP-13082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Bokor updated HADOOP-13082:
----------------------------------
    Description: 
FileSystemContractBaseTest#testRenameFileMoveToNonExistentDirectory: creates a 
file then move it to a non-existing directory. It should fail but it will not 
(with RawLocalFileSystem) because in RawLocalFileSystem#rename(Path, Path) 
method we have a fallback behavior that accomplishes the rename by a full copy. 
The full copy will create the new directory and copy the file there.

I see two possible solutions here:
#Remove the fallback full copy behavior
#Before full cp we should check whether the parent directory exists or not. If 
not return false an do not do the full copy.

  was:
FileSystemContractBaseTest#testMkdirsWithUmask is changing umask under the 
filesystem. RawLocalFileSystem reads the config on startup so it will not react 
if we change the umask.
It blocks [HADOOP-7363|https://issues.apache.org/jira/browse/HADOOP-7363] since 
testMkdirsWithUmask test will never work with RawLocalFileSystem.


> RawLocalFileSystem does not fail when moving file to a non-existing directory
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-13082
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13082
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: Andras Bokor
>            Assignee: Andras Bokor
>
> FileSystemContractBaseTest#testRenameFileMoveToNonExistentDirectory: creates 
> a file then move it to a non-existing directory. It should fail but it will 
> not (with RawLocalFileSystem) because in RawLocalFileSystem#rename(Path, 
> Path) method we have a fallback behavior that accomplishes the rename by a 
> full copy. The full copy will create the new directory and copy the file 
> there.
> I see two possible solutions here:
> #Remove the fallback full copy behavior
> #Before full cp we should check whether the parent directory exists or not. 
> If not return false an do not do the full copy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to