[
https://issues.apache.org/jira/browse/HADOOP-13098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271744#comment-15271744
]
Mingliang Liu commented on HADOOP-13098:
----------------------------------------
Thanks for filing this, [~djp].
# I'm not favor of
{{assertTrue(Level.ERROR.equals(log.getEffectiveLevel()));}}. IMHO
{{assertEquals("some case specific error message", Level.ERROR,
log.getEffectiveLevel());}} seems better.
# My minor concern is that, in case of invalid argument, the error message
should better include the original user-provided {{level}}. Or else, if the
user provides {{inffo}}, and we report error message saying {{Bad level :
INFFO}}. The user may be confused as she's pretty sure she did not input any
uppercase char.
# That said, {{org.apache.log4j.Level.toLevel()}} accepts mixing
upper/lower-case string. We can simply replace the {{level.equals()}} with
{{level.equalsIgnoreCase()}}. Changing the input to uppercase should work just
work fine. {{java.util.logging.Logger}} seems different.
+1 (non-binding) after the comments above are considered/addressed.
> Dynamic LogLevel setting page should accept log level string with mixing
> upper case and lower case
> --------------------------------------------------------------------------------------------------
>
> Key: HADOOP-13098
> URL: https://issues.apache.org/jira/browse/HADOOP-13098
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: HADOOP-13098.patch
>
>
> Our current logLevel settings: http://deamon_web_service_address/logLevel
> only accept full Upper Case string of log level that means "Debug" or "debug"
> is treated as bad log level in setting. I think we should enhance the tools
> to ignore upper/lower cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
