[
https://issues.apache.org/jira/browse/HADOOP-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272965#comment-15272965
]
Chris Nauroth commented on HADOOP-13103:
----------------------------------------
The patch looks good to me overall. I just have one question. The old code
had one attempt outside the {{while}} loop and then up to 3 more attempts
inside the {{while}} loop. With this patch, all attempts are collapsed into a
single {{for}} loop with up to 3 iterations. I am wondering if
{{RECONNECT_RETRY_COUNT}} should be increased to 4 to preserve the old behavior
of "4 total attempts". Let me know your thoughts.
> Group resolution from LDAP may fail on
> javax.naming.ServiceUnavailableException
> -------------------------------------------------------------------------------
>
> Key: HADOOP-13103
> URL: https://issues.apache.org/jira/browse/HADOOP-13103
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Attachments: c13103_20160505.patch
>
>
> According to the
> [javadoc|https://docs.oracle.com/javase/7/docs/api/javax/naming/ServiceUnavailableException.html],
> ServiceUnavailableException is thrown when attempting to communicate with a
> directory or naming service and that service is not available. It might be
> unavailable for different reasons. For example, the server might be too busy
> to service the request, or the server might not be registered to service any
> requests, etc.
> We should retry on it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
