[ 
https://issues.apache.org/jira/browse/HADOOP-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918729#action_12918729
 ] 

Eli Collins commented on HADOOP-6916:
-------------------------------------

Hey Oleg,

* Doesn't pos and filePos need to be updated when opening for append?
* Doesn't S3OutputStream#setBlocks need to be synchronized? Why does it copy 
the blocks?
* Make sure the unit tests exercise calling close after append.
* Have you tested this on S3? eg by setting test.fs.s3.name in 
src/test/core-site.xml?

Hudson currently running, please use ant test-patch from an svn checkout.

Thanks,
Eli

> Implement append operation for S3FileSystem
> -------------------------------------------
>
>                 Key: HADOOP-6916
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6916
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs/s3
>    Affects Versions: 0.20.2, 0.22.0
>            Reporter: Oleg Aleshko
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: s3_append1.patch
>
>
> Currently org.apache.hadoop.fs.s3.S3FileSystem#append throws an 
> IOException("Not supported");
> S3FileSystem should be able to support appending, possibly via common block 
> storage logic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to