[
https://issues.apache.org/jira/browse/HADOOP-10230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284069#comment-15284069
]
Hiroshi Ikeda commented on HADOOP-10230:
----------------------------------------
I don't think such a contract is really needed, because I think no one makes
use of the contract, and that just makes the implementation messy.
It is enough to remove the contract of throwing NPE, and add non-null
preconditions if needed (though passing a null argument is generally prohibited
unless it is specified what the null means).
> GSetByHashMap breaks contract of GSet
> -------------------------------------
>
> Key: HADOOP-10230
> URL: https://issues.apache.org/jira/browse/HADOOP-10230
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.2.0
> Reporter: Hiroshi Ikeda
> Assignee: Andres Perez
> Priority: Trivial
> Attachments: HADOOP-10230.001.patch, HADOOP-10230.002.patch
>
>
> The contract of GSet says it is ensured to throw NullPointerException if a
> given argument is null for many methods, but GSetByHashMap doesn't. I think
> just writing non-null preconditions for GSet are required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
