[ 
https://issues.apache.org/jira/browse/HADOOP-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286456#comment-15286456
 ] 

Steve Loughran commented on HADOOP-12667:
-----------------------------------------

Looking at patch

# All the check that is needed is a {{getFileStatus()}} + check there is a 
parent dir. But as create() does that anyway, it could be optimised by having 
the internal create do/not do this
# looking at S3A, I'm not sure that parent dirs are created right now. I guess 
it relies on the fact that by creating a long blob path, the parent dir comes 
in implicitly. But what if there is a parent and it is a file? Maybe we need a 
test case in {{AbstractContractCreateTest}} to make sure that it's an error to 
attempt to do that.
# this implementation of {{createNonRecursive()}} will need that.
# I don't see any tests for {{createNonRecursive()}}  in the filesystem 
contract tests, or indeed, anything in 
{{hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md}}
 to define the semantics of the operation. I'm afraid that'll be needed. The 
test you've written will be a foundation for that, though it'll need more tests 
(parent is file, parent is root dir, overwrite = true, overwrite = false)

> s3a: Support createNonRecursive API
> -----------------------------------
>
>                 Key: HADOOP-12667
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12667
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-12667.001.patch
>
>
> HBase and other clients rely on the createNonRecursive API, which was 
> recently un-deprecated. S3A currently does not support it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to