[ 
https://issues.apache.org/jira/browse/HADOOP-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287589#comment-15287589
 ] 

Arpit Agarwal commented on HADOOP-13159:
----------------------------------------

+1 for the v02 patch. Actually you are avoiding 19 invocations of 
topNCallers.size() with the update.

> Fix potential NPE in Metrics2 source for DecayRpcScheduler
> ----------------------------------------------------------
>
>                 Key: HADOOP-13159
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13159
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 2.8.0
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HADOOP-13159.00.patch, HADOOP-13159.01.patch, 
> HADOOP-13159.02.patch
>
>
> HADOOP-12985 introduced a few metrics2 counters for DecayRpcScheduler. The 
> counters should be initialized before the updater thread is created/executed. 
> Otherwise, this is a chance of NPE  if the updater thread get executed before 
> the counters are fully initialized. I will post a patch for it shortly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to