[
https://issues.apache.org/jira/browse/HADOOP-13174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290122#comment-15290122
]
Yongjun Zhang commented on HADOOP-13174:
----------------------------------------
Hi [~xiaochen],
Thanks for reporting the issue and working on the patch. I have a few comments
here:
1. AuthenticatedURL:
{{LOG.trace}} is added for {{if}} condition {{if (value.length() > 0) {}}, do
we need to trace the {{else}} condition?
2. AuthenticatedURL. For all LOG.trace added to this class, suggest to add
{{respCode}}'s value to the trace log message, so to distinguish the cases.
3. AuthenticationFilter:
{code}
LOG.debug("managementOperation returned false.");
{code}
suggest to include the parameter value passed to managementOperation {{token,
httpRequest, httpResponse}}
4. KMCClientProvider
{code}
LOG.trace("Creating connection from url: {}", url);
{code}
suggest to add {{method}} parameter to the log
5. KMCClientProvider
Suggest to add {{conn}} to the first trace log of {{call}}, plus
{{expectedResponse}}, {{authRetryCount}}
Thanks.
> Add more debug logs for delegation tokens and authentication
> ------------------------------------------------------------
>
> Key: HADOOP-13174
> URL: https://issues.apache.org/jira/browse/HADOOP-13174
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Priority: Minor
> Attachments: HADOOP-13174.01.patch, HADOOP-13174.02.patch
>
>
> Recently I debugged several authentication related problems, and found that
> the debug logs are not enough to identify a problem.
> This jira improves it by adding more debug/trace logs along the line.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
