[
https://issues.apache.org/jira/browse/HADOOP-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292747#comment-15292747
]
Walter Su commented on HADOOP-12974:
------------------------------------
1. DF constructor is DF(File path, long dfInterval)
{code}
- this.df = new DF(builder.getPath(), builder.getInitialUsed());
+ this.df = new DF(builder.getPath(), builder.getInterval());
{code}
2. About test. Current implementation of {{DF.java}} works on windows. And I
think assertTrue(instance.getUsed() >= FILE_SIZE - 20); almost always true,
since there's other files on the filesystem and other tests running. It's hard
to create a mount point in the test, how about we verify that getUsed() is
changing.
> Create a CachingGetSpaceUsed implementation that uses df
> --------------------------------------------------------
>
> Key: HADOOP-12974
> URL: https://issues.apache.org/jira/browse/HADOOP-12974
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 2.9.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HADOOP-12974v0.patch, HADOOP-12974v1.patch,
> HADOOP-12974v2.patch, HADOOP-12974v3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
