[
https://issues.apache.org/jira/browse/HADOOP-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293980#comment-15293980
]
Steven Wong commented on HADOOP-13130:
--------------------------------------
Commenting on patch 014...
{{TestS3AAWSCredentialsProvider.testBadConfiguration}} has:
{code}
if (!(e.getCause() instanceof ClassNotFoundException)) {
LOG.error("Unexpected nested cause: {} in {}", e.getCause(), e, e);
fail("no exception");
throw e;
}
{code}
Choose one to keep: either the {{fail}} method call or the {{throw}} statement,
because the first hides the second. If keeping the {{fail}} call, its message
is inaccurate and should change.
> s3a failures can surface as RTEs, not IOEs
> ------------------------------------------
>
> Key: HADOOP-13130
> URL: https://issues.apache.org/jira/browse/HADOOP-13130
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.7.2
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-13130-001.patch, HADOOP-13130-002.patch,
> HADOOP-13130-002.patch, HADOOP-13130-003.patch, HADOOP-13130-004.patch,
> HADOOP-13130-005.patch, HADOOP-13130-branch-2-006.patch,
> HADOOP-13130-branch-2-007.patch, HADOOP-13130-branch-2-008.patch,
> HADOOP-13130-branch-2-009.patch, HADOOP-13130-branch-2-010.patch,
> HADOOP-13130-branch-2-011.patch, HADOOP-13130-branch-2-012.patch,
> HADOOP-13130-branch-2-013.patch, HADOOP-13130-branch-2-014.patch,
> HADOOP-13130-branch-2-015.patch, HADOOP-13130-branch-2-016.patch
>
>
> S3A failures happening in the AWS library surface as
> {{AmazonClientException}} derivatives, rather than IOEs. As the amazon
> exceptions are runtime exceptions, any code which catches IOEs for error
> handling breaks.
> The fix will be to catch and wrap. The hard thing will be to wrap it with
> meaningful exceptions rather than a generic IOE. Furthermore, if anyone has
> been catching AWS exceptions, they are going to be disappointed. That means
> that fixing this situation could be considered "incompatible" —but only for
> code which contains assumptions about the underlying FS and the exceptions
> they raise.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
