[ 
https://issues.apache.org/jira/browse/HADOOP-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiao Chen updated HADOOP-12893:
-------------------------------
    Attachment: HADOOP-12893.004.patch

Thanks a lot [~andrew.wang] for responding from you vacation! I went ahead and 
updated the L&Ns from our co-edited spreadsheet.

It fixes:
* From Andrew's 
[comment|https://issues.apache.org/jira/browse/HADOOP-12893?focusedCommentId=15284066&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15284066]:
** Not listing ALv2 dependencies in LICENSE
** Add version numbers to dependencies
** No copyrights for BSD / MIT licensed deps in NOTICE
** For the scripts, since we have it in the spreadsheet now, I'm thinking maybe 
we can make it viewable to all?
** {quote} In the L&N we say whether something applies to the binary or the 
source
distribution. I saw this elsewhere, and it really reduces the POM work
required.
{quote}
This is done in this patch, I mentioned in LICENSE that it applies to source or 
binary (or both). Looking at the NOTICE, it seems already saying 'The binary 
distribution of this product bundles binaries of'..., so I think we're good 
using binary only.
** Reflected the offline idea of merging components under same dependency, to 
reduce the list.

* From Bill's 
[comment|https://issues.apache.org/jira/browse/HADOOP-12893?focusedCommentId=15288105&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15288105]:
** Dual-licensed/Tri-licensed deps are now listed under more permissive license 
(ASLv2 > others)
** junit and mockito are currently bundled, and I'm removing them from being 
bundled in this patch. Also thanks Allen for the pointer jira.
** jdiff is not bundled. But it is used in source (in 
{{hadoop-project/pom.xml}}). *I'm not sure how to proceed with this one... 
Shall we 1) try remove it completely 2) as-is 3) replace it with something 
else?* We listed [jdiff|http://javadiff.sourceforge.net/] in LICENSE for source 
distribution (for honesty...)
** Unfortunately we don't have a way to automatically check whether each 
dependency should be bundled. So if anyone sees another dependency shouldn't be 
bundled, please feel free to comment.

Thank you again to everyone for the review and feedback. :) 

> Verify LICENSE.txt and NOTICE.txt
> ---------------------------------
>
>                 Key: HADOOP-12893
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12893
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>            Reporter: Allen Wittenauer
>            Assignee: Xiao Chen
>            Priority: Blocker
>         Attachments: HADOOP-12893.002.patch, HADOOP-12893.003.patch, 
> HADOOP-12893.004.patch, HADOOP-12893.01.patch
>
>
> We have many bundled dependencies in both the source and the binary artifacts 
> that are not in LICENSE.txt and NOTICE.txt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to