[
https://issues.apache.org/jira/browse/HADOOP-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924465#action_12924465
]
Chris Nauroth commented on HADOOP-7006:
---------------------------------------
It appears that this was introduced with changeset 949658. Here is a partial
diff of org.apache.hadoop.fs.FileUtil:
{noformat}
@@ -258,7 +258,7 @@
Configuration conf, String addString) throws
IOException {
dstFile = checkDest(srcDir.getName(), dstFS, dstFile, false);
- if (!srcFS.getFileStatus(srcDir).isDir())
+ if (srcFS.getFileStatus(srcDir).isDirectory())
return false;
{noformat}
Notice that in addition to switching from isDir() to isDirectory(), this change
also dropped the negation on the front of the condition. I'll attach a simple
one-line patch to restore functionality. I've also added a unit test to cover
the FileUtil.copyMerge API. I'd like to volunteer for HADOOP-6387 next, and I
want this unit test in place as a regression test while I work on that.
> hadoop fs -getmerge does not work using codebase from trunk.
> ------------------------------------------------------------
>
> Key: HADOOP-7006
> URL: https://issues.apache.org/jira/browse/HADOOP-7006
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Chris Nauroth
> Fix For: 0.22.0
>
>
> Running the codebase from trunk, the hadoop fs -getmerge command does not
> work. As implemented in prior versions (i.e. 0.20.2), I could run hadoop fs
> -getmerge pointed at a directory containing multiple files. It would merge
> all files into a single file on the local file system. Running the same
> command using the codebase from trunk, it looks like nothing happens.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.