[
https://issues.apache.org/jira/browse/HADOOP-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-13171:
-----------------------------------
Attachment: HADOOP-13171-branch-2.8-017.patch
Unfortunately, this cannot go to branch-2.8 as is. First, there is a minor
merge conflict in {{TestS3ADeleteManyFiles}} due to lack of HADOOP-12753 in
branch-2.8. That's trivial to fix, and I would have committed, but the more
significant problem is lack of {{GenericTestUtils#getTestDir}} on branch-2.8,
which caused a compilation failure. This is similar to what happened with
HADOOP-13145, and we can use the same kind of workaround: inline the test
directory creation. For this part, I'd prefer to put a branch-2.8-specific
patch through pre-commit.
Steve, I took the liberty of making a branch-2.8 patch. Could I please get
your review on just the change to deal with lack of
{{GenericTestUtils#getTestDir}}? For convenience, here is the only diff
compared to the branch-2 patch, in {{TestS3AFileOperationCost}}:
{code}
- File localTestDir = getTestDir("tmp");
+ String testDirProp = System.getProperty("test.build.data",
+ "target" + File.separator + "test" + File.separator + "data");
+ File localTestDir = new File(testDirProp, "tmp").getAbsoluteFile();
{code}
> Add StorageStatistics to S3A; instrument some more operations
> -------------------------------------------------------------
>
> Key: HADOOP-13171
> URL: https://issues.apache.org/jira/browse/HADOOP-13171
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-13171-014.patch, HADOOP-13171-016.patch,
> HADOOP-13171-branch-2-001.patch, HADOOP-13171-branch-2-002.patch,
> HADOOP-13171-branch-2-003.patch, HADOOP-13171-branch-2-004.patch,
> HADOOP-13171-branch-2-005.patch, HADOOP-13171-branch-2-006.patch,
> HADOOP-13171-branch-2-007.patch, HADOOP-13171-branch-2-008.patch,
> HADOOP-13171-branch-2-009.patch, HADOOP-13171-branch-2-010.patch,
> HADOOP-13171-branch-2-011.patch, HADOOP-13171-branch-2-012.patch,
> HADOOP-13171-branch-2-013.patch, HADOOP-13171-branch-2-015.patch,
> HADOOP-13171-branch-2.8-017.patch
>
>
> Add {{StorageStatistics}} support to S3A, collecting the same metrics as the
> instrumentation, but sharing across all instances.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
