[ https://issues.apache.org/jira/browse/HADOOP-12709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313026#comment-15313026 ]
Chris Nauroth commented on HADOOP-12709: ---------------------------------------- The patch looks good to me too. I don't have any further comments, but it looks like it needs to be rebased after a few recent commits. The current scope of this JIRA is stated as "deprecate from branch-2 and remove from trunk". I am wondering if it makes more sense to split those 2 tasks into 2 separate JIRAs. That way, we'd be able to enter a release note for 2.x that says "it's going away soon" and a separate release note for 3.0 that says "it's gone". What are your thoughts? Also, Mingliang, were you planning on doing the deprecation part of this too? > Deprecate s3:// in branch-2,; cut from trunk > -------------------------------------------- > > Key: HADOOP-12709 > URL: https://issues.apache.org/jira/browse/HADOOP-12709 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/s3 > Affects Versions: 2.8.0 > Reporter: Steve Loughran > Assignee: Mingliang Liu > Attachments: HADOOP-12709.000.patch, HADOOP-12709.001.patch, > HADOOP-12709.002.patch, HADOOP-12709.003.patch, HADOOP-12709.004.patch > > > The fact that s3:// was broken in Hadoop 2.7 *and nobody noticed until now* > shows that it's not being used. while invaluable at the time, s3n and > especially s3a render it obsolete except for reading existing data. > I propose > # Mark Java source as {{@deprecated}} > # Warn the first time in a JVM that an S3 instance is created, "deprecated > -will be removed in future releases" > # in Hadoop trunk we really cut it. Maybe have an attic project (external?) > which holds it for anyone who still wants it. Or: retain the code but remove > the {{fs.s3.impl}} config option, so you have to explicitly add it for use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org