[
https://issues.apache.org/jira/browse/HADOOP-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314974#comment-15314974
]
Chris Nauroth commented on HADOOP-13105:
----------------------------------------
[~liuml07], patch 003 looks good. I just have one more request. In the tests,
please declare {{finLatch}} as {{final}}. Without that, the patch will cause
compilation to fail on branch-2 with the errors shown below.
This didn't show up in pre-commit, because pre-commit ran against trunk, which
is building with Java 8. In Java 8, they have introduced the concept of
"effectively final" variables, which means that Java 8 auto-detected that those
variables are final, because they were assigned only once.
{code}
[ERROR]
/Users/chris/git/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java:[232,15]
local variable finLatch is accessed from within inner class; needs to be
declared final
[ERROR]
/Users/chris/git/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java:[288,15]
local variable finLatch is accessed from within inner class; needs to be
declared final
{code}
> Support timeouts in LDAP queries in LdapGroupsMapping.
> ------------------------------------------------------
>
> Key: HADOOP-13105
> URL: https://issues.apache.org/jira/browse/HADOOP-13105
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.0.0-alpha1
> Reporter: Chris Nauroth
> Assignee: Mingliang Liu
> Attachments: HADOOP-13105.000.patch, HADOOP-13105.001.patch,
> HADOOP-13105.002.patch, HADOOP-13105.003.patch
>
>
> {{LdapGroupsMapping}} currently does not set timeouts on the LDAP queries.
> This can create a risk of a very long/infinite wait on a connection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
