[
https://issues.apache.org/jira/browse/HADOOP-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320012#comment-15320012
]
Vinitha Reddy Gankidi commented on HADOOP-13189:
------------------------------------------------
[~xyao] Thanks for the review. The 2nd parameter of the FairCallQueue
constructor is the per queue capacity in the current implementation. However,
this patch makes it the total capacity of all subqueues. So, this change is
needed.
It would be better to keep the capacity allocation to the subqueues flexible.
Instead of validating the internal subqueue capacity allocation, I will add a
test that validates that the total capacity of all subqueues equals the
maxQueueSize.
> FairCallQueue makes callQueue larger than the configured capacity.
> ------------------------------------------------------------------
>
> Key: HADOOP-13189
> URL: https://issues.apache.org/jira/browse/HADOOP-13189
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 2.6.0
> Reporter: Konstantin Shvachko
> Assignee: Vinitha Reddy Gankidi
> Attachments: HADOOP-13189.001.patch
>
>
> {{FairCallQueue}} divides {{callQueue}} into multiple (4 by default)
> sub-queues, with each sub-queue corresponding to a different level of
> priority. The constructor for {{FairCallQueue}} takes the same parameter
> {{capacity}} as the default CallQueue implementation, and allocates all its
> sub-queues of size {{capacity}}. With 4 levels of priority (sub-queues) by
> default it results in the total callQueue size 4 times larger than it should
> be based on the configuration.
> {{capacity}} should be divided by the number of sub-queues at some place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
