[
https://issues.apache.org/jira/browse/HADOOP-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323041#comment-15323041
]
Jing Zhao commented on HADOOP-13249:
------------------------------------
The patch looks good to me overall. Some minor comments:
# The failed unit test is related to the patch
# No need to convert InterruptedIOException into IOException since
{{InterruptedIOException}} is already an {{IOException}}.
{code}
306 throw (IOException)new InterruptedIOException("Retry
interrupted"
307 ).initCause(e);
{code}
Other comments, [[email protected]]?
> RetryInvocationHandler need wrap InterruptedException in IOException when
> call Thread.sleep
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-13249
> URL: https://issues.apache.org/jira/browse/HADOOP-13249
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 2.8.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: HADOOP-13249.000.patch, HADOOP-13249.001.patch
>
>
> RetryInvocationHandler need wrap InterruptedException in IOException when
> call Thread.sleep. Otherwise InterruptedException can't be handled correctly
> by other components such as HDFS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
