[
https://issues.apache.org/jira/browse/HADOOP-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325102#comment-15325102
]
Chris Nauroth commented on HADOOP-13257:
----------------------------------------
[~vishwajeet.dusane], I've taken the liberty of assigning this to you
initially, but please feel free to unassign if that's not right.
Here is a copy-paste of comments from [[email protected]] on HADOOP-12875.
Various tests are being skipped with a "BUG" commentary. those are signs of
where the FS doesn't behave as expected. It's generally acceptable to skip
tests where the feature is unimplemented especially in the quirks of object
stores —but not where things are fundamentally at odds with the filesystem
specification As an example, the test testRmNonEmptyRootDirNonRecursive() is
skipped. That test is verifying a core feature of the FS behaviour. Same for
AbstractContractMkdirTest.testNoMkdirOverFile(), where we say "you cannot
create a directory where there is a file".
TestListStatus uses System.out. Replace with logging
Contract tests must not be using fs.default.fs as source; makes it impossible
to have >1 FS in a test module. Look at how hadoop-aws defines a separate FS
URI for each FS in options like test.fs.s3n.name and test.fs.s3a.name
I don't understand why every setup has been overridden with a check for the
test being enabled. The AdlStorageContract class should subclass isEnabled()
for this
Add a test for a seek of a long negative number, expect it throw an
EOFException. Your seek() bounds checking only checks for -1, which is only a
small subset of the possible negative seek ranges. This test should actually go
into AbstractContractSeekTest, as we should see what other filesystems get up
to.
Rather than skip some of AbstractContractMkdirTest, these MUST be fixed.
In TestConfigurationSetting}, all the close() calls must be designed to
complete even in the presence of assertion failures. Use try-with-resources.
> Improve Azure Data Lake contract tests.
> ---------------------------------------
>
> Key: HADOOP-13257
> URL: https://issues.apache.org/jira/browse/HADOOP-13257
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Chris Nauroth
> Assignee: Vishwajeet Dusane
>
> HADOOP-12875 provided the initial implementation of the FileSystem contract
> tests covering Azure Data Lake. This issue tracks subsequent improvements on
> those test suites for improved coverage and matching the specified semantics
> more closely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
