[ 
https://issues.apache.org/jira/browse/HADOOP-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325115#comment-15325115
 ] 

Chris Nauroth commented on HADOOP-12875:
----------------------------------------

Steve, thank you for the flexibility.  I have filed HADOOP-13257 and 
copy-pasted your comments.

[~vishwajeet.dusane], the remaining thing we need to do on this patch is to 
address the warnings from pre-commit:

# Please fix the Findbugs warning.
# Please fix the Checkstyle warnings.  Sometimes Checkstyle warnings are overly 
pedantic and we proceed without addressing all of them.  Feel free to ask me if 
you think you're looking at a warning that might fall into that category, and 
I'd be happy to advise on whether or not I think it's necessary.
# Pre-commit is reporting tests as failing, because it won't have ADL 
credentials.  You probably need to adjust the test configuration setup and the 
pom.xml file so that tests won't get triggered if the credentials file is 
missing.  I recommend taking a look at the pom.xml in hadoop-aws for an example 
of how to do that.

bq. I just do think all those skipped contract tests need to get working, for 
the benefit of everyone.

Absolutely.  They are invaluable for catching issues before more costly 
long-running system tests.

> [Azure Data Lake] Support for contract test and unit test cases
> ---------------------------------------------------------------
>
>                 Key: HADOOP-12875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12875
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: fs, fs/azure, tools
>            Reporter: Vishwajeet Dusane
>            Assignee: Vishwajeet Dusane
>         Attachments: Hadoop-12875-001.patch, Hadoop-12875-002.patch, 
> Hadoop-12875-003.patch, Hadoop-12875-004.patch
>
>
> This JIRA describes contract test and unit test cases support for azure data 
> lake file system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to