[
https://issues.apache.org/jira/browse/HADOOP-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329257#comment-15329257
]
Masatake Iwasaki commented on HADOOP-13244:
-------------------------------------------
+1, checking this in.
bq. Luckily, I search the code base and found most callers invoke the
constructor with queueSizePerHandler=-1.
I could not find the code setting {{queueSizePerHandler}} except tests. I don't
know the background why HADOOP-6764 added this. It might be better to be
cleaned up in the follow-up.
> o.a.h.ipc.Server#Server should honor handlerCount when queueSizePerHandler is
> specified in consturctor
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-13244
> URL: https://issues.apache.org/jira/browse/HADOOP-13244
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Reporter: Xiaoyu Yao
> Assignee: Kai Sasaki
> Priority: Minor
> Attachments: HADOOP-13244.01.patch
>
>
> In the code below, {{this.maxQueueSize = queueSizePerHandler;}} should be
> {{ this.maxQueueSize = handlerCount * queueSizePerHandler;}}. Luckily, I
> search the code base and found most callers invoke the constructor with
> queueSizePerHandler=-1. This ticket is opened to make it correct for the case
> when queueSizePerHandler is not -1.
> {code}
> if (queueSizePerHandler != -1) {
> this.maxQueueSize = queueSizePerHandler;
> } else {
> this.maxQueueSize = handlerCount * conf.getInt(
> CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_KEY,
> CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_DEFAULT);
>
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
