[ 
https://issues.apache.org/jira/browse/HADOOP-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330927#comment-15330927
 ] 

Ming Ma commented on HADOOP-13189:
----------------------------------

[~shv], the reason I asked is refreshCallQueue should switch to the new call 
queue right away while draining existing calls. Just to confirm, this patch 
does change the meaning of call queue size for FairCallQueue(it was meant for 
sub queue, but now it is for the aggregated size). It really depends on how you 
interpret it, it could be a backward compatibility issue, or just bug fix. What 
is your take?

> FairCallQueue makes callQueue larger than the configured capacity.
> ------------------------------------------------------------------
>
>                 Key: HADOOP-13189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 2.6.0
>            Reporter: Konstantin Shvachko
>            Assignee: Vinitha Reddy Gankidi
>         Attachments: HADOOP-13189.001.patch, HADOOP-13189.002.patch, 
> HADOOP-13189.003.patch
>
>
> {{FairCallQueue}} divides {{callQueue}} into multiple (4 by default) 
> sub-queues, with each sub-queue corresponding to a different level of 
> priority. The constructor for {{FairCallQueue}} takes the same parameter 
> {{capacity}} as the default CallQueue implementation, and allocates all its 
> sub-queues of size {{capacity}}. With 4 levels of priority (sub-queues) by 
> default it results in the total callQueue size 4 times larger than it should 
> be based on the configuration.
> {{capacity}} should be divided by the number of sub-queues at some place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to