[
https://issues.apache.org/jira/browse/HADOOP-13242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334707#comment-15334707
]
Chris Nauroth commented on HADOOP-13242:
----------------------------------------
Thank you to Checkstyle for making a significant catch here:
{code}
private String OAUTH_CLIENT_ID_KEY = "dfs.webhdfs.oauth2.client.id";
private String OAUTH_REFRESH_URL_KEY = "dfs.webhdfs.oauth2.refresh.url";
{code}
Checkstyle is reporting that the variable names don't fit the coding standard,
but really the problem is that these should be declared as constants. For each
of these, please change {{private String}} to {{private static final String}}.
Let's also remove the import of {{org.apache.hadoop.hdfs.web.oauth2.Utils}},
because it resides in the same package.
I expect that will be the last round of nitpicks, and one more revision to
address the above should finish it.
> Authenticate to Azure Data Lake using client ID and keys
> --------------------------------------------------------
>
> Key: HADOOP-13242
> URL: https://issues.apache.org/jira/browse/HADOOP-13242
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure
> Environment: All
> Reporter: Atul Sikaria
> Assignee: Atul Sikaria
> Attachments: HADOOP-13242-003.patch, HADOOP-13242-004.patch,
> HDFS-10462-001.patch, HDFS-10462-002.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Current OAuth2 support (used by HADOOP-12666) supports getting a token using
> client creds. However, the client creds support does not pass the "resource"
> parameter required by Azure AD. This work adds support for the "resource"
> parameter when acquring the OAuth2 token from Azure AD, so the client
> credentials can be used to authenticate to Azure Data Lake.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
