[
https://issues.apache.org/jira/browse/HADOOP-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HADOOP-13291:
-----------------------------------
Priority: Major (was: Minor)
Description:
To probe a stat in {{StorageStatistics}}, users can use the
{{StorageStatistics#isTracked()}} API. Currently {{DFSOpsCountStatistics}}
implements this function wrongly. {{S3AStorageStatistics}} borrowed the same
idea and also has the same error.
# The {{isTracked()}} is not correctly implemented. I believe this was an
omission in code.
# {{isTracked()}} checks a stat with operation symbol (instead of enum name).
{{getLongStatistics()}} should return LongStatistics iterators with symbol as
name, instead of the enum variable name. Or else,
{{isTracked(getLongStatistics().next().getName());}} returns false. This will
lead to confusion.
was:
To probe a stat in {{StorageStatistics}}, users can use the
{{StorageStatistics#isTracked()}} API. Currently {{DFSOpsCountStatistics}}
implements this function wrongly. {{S3AStorageStatistics}} borrowed the same
idea and also has the same error.
# The {{isTracked()}} is not correctly implemented. I believe this was an
omission in code.
# {{isTracked()}} checks a stat with operation symbol (instead of enum name).
{{getLongStatistics()}} should return LongStatistics iterators with symbol as
name, instead of the enum variable name.
This jira is to make the above two simple things right.
> Probing stats in DFSOpsCountStatistics/S3AStorageStatistics should be
> correctly implemented
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-13291
> URL: https://issues.apache.org/jira/browse/HADOOP-13291
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 2.8.0
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
>
> To probe a stat in {{StorageStatistics}}, users can use the
> {{StorageStatistics#isTracked()}} API. Currently {{DFSOpsCountStatistics}}
> implements this function wrongly. {{S3AStorageStatistics}} borrowed the same
> idea and also has the same error.
> # The {{isTracked()}} is not correctly implemented. I believe this was an
> omission in code.
> # {{isTracked()}} checks a stat with operation symbol (instead of enum name).
> {{getLongStatistics()}} should return LongStatistics iterators with symbol as
> name, instead of the enum variable name. Or else,
> {{isTracked(getLongStatistics().next().getName());}} returns false. This will
> lead to confusion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
