[
https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342205#comment-15342205
]
Daniel Templeton commented on HADOOP-13254:
-------------------------------------------
Thanks, [~yufeigu]. Almost there. We're now down to quibbles:
In {{TestBasicDiskValidator.checkDirs()}}, the try-finally needs to start
immediately after you create the file.
{code}
* Returns {@link DiskValidator} instance corresponding to its name.
* DiskValidator can be "basic" for BasicDiskValidator;
* @param diskValidator canonical class name, e.g. "basic"
{code}
has a couple of issues. In the second line, it would be clearer if
"DiskValidator" were "The parameter" or "The diskValidator parameter". Also in
the second line, "BasicDiskValidator" should be a link. In the @param tag,
"e.g." should be "for example" per the javadoc guidelines.
{code}
* A {@link DiskValidator} is the interface of a disk validator.
{code}
should not use a link for {{DiskValidator}} since the comment is in the
{{DiskValidator}} class.
{code}
/**
* The basic DiskValidator do the same thing as existing DiskChecker do.
*/
{code}
This comment would be clearer if it said that {{BasicDiskValidator}} is a
wrapper around {{DiskChecker}}.
> Make Diskchecker Pluggable
> --------------------------
>
> Key: HADOOP-13254
> URL: https://issues.apache.org/jira/browse/HADOOP-13254
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch,
> HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch,
> HADOOP-13254.006.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
