[ https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363111#comment-15363111 ]
Ray Chiang commented on HADOOP-13254: ------------------------------------- Changed summary to match code changes. I'm assuming the configuration settings will go into YARN-5137. More minor nits: - I see that DiskValidatorFactory#getInstance(String) has @param and @throws, but DiskValidatorFactory#getInstance(Class) does not. I know it's a bit redundant, but I see similar classes have the Javadoc for both methods. - Make the InterfaceAudience settings more conservative for now (since DiskChecker is @InterfaceAudience.Private): -- Keep DiskValidator as @InterfaceAudience.Private (i.e. Hadoop only) for now. -- For DiskValidatorFactory, remove @InterfaceStability.Evolving. > Create framework for configurable disk checkers > ----------------------------------------------- > > Key: HADOOP-13254 > URL: https://issues.apache.org/jira/browse/HADOOP-13254 > Project: Hadoop Common > Issue Type: Bug > Components: util > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch, > HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch, > HADOOP-13254.006.patch, HADOOP-13254.007.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org