[
https://issues.apache.org/jira/browse/HADOOP-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366971#comment-15366971
]
Mingliang Liu edited comment on HADOOP-13351 at 7/7/16 11:46 PM:
-----------------------------------------------------------------
The v1 patch is also the best effort I can figure out so far. Thanks for the
patch.
{code}
void testSpecifiedSendBufferSize() throws IOException {
final int mySendBufferSize = 64 * 1024; // 64 KB
{code}
To make the test covers the specified value, I'd suggest we change
{{mySendBufferSize}} to be a different value (say, 512KB). The default value is
128KB >= 64KB. As a result, the test can pass without the following the
statement which sets the specific value:
{code}
conf.setInt(DFS_CLIENT_SOCKET_SEND_BUFFER_SIZE_KEY, mySendBufferSize);
{code}
was (Author: liuml07):
The v1 patch is also the best effort I can figure out so far. Thanks for the
patch.
{code}
void testSpecifiedSendBufferSize() throws IOException {
final int mySendBufferSize = 64 * 1024; // 64 KB
{code}
To make the test covers the specified value, I'd suggest we change
{{mySendBufferSize}} to be a different value (say, 32KB). The default value is
128KB >= 64KB. As a result, the test can pass without the following the
statement which sets the specific value:
{code}
conf.setInt(DFS_CLIENT_SOCKET_SEND_BUFFER_SIZE_KEY, mySendBufferSize);
{code}
> TestDFSClientSocketSize buffer size tests are flaky
> ---------------------------------------------------
>
> Key: HADOOP-13351
> URL: https://issues.apache.org/jira/browse/HADOOP-13351
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.8.0, 3.0.0-alpha1
> Reporter: Aaron Fabbri
> Attachments: HADOOP-13551.001.patch
>
>
> {{TestDFSClientSocketSize}} has two tests that assert that a value that was
> set via {{java.net.Socket#setSendBufferSize}} is equal to the value
> subsequently returned by {{java.net.Socket#getSendBufferSize}}.
> These tests are flaky when we run them. The occasionally fail.
> This is expected behavior, actually, because
> {{Socket#setSendBufferSize()}}[is only a
> hint|https://docs.oracle.com/javase/7/docs/api/java/net/Socket.html#setSendBufferSize(int)].
> (Similar to how the underlying libc {{setsockopt(SO_SNDBUF)}} works).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
