[
https://issues.apache.org/jira/browse/HADOOP-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368024#comment-15368024
]
Aaron Fabbri commented on HADOOP-13351:
---------------------------------------
[~liuml07] seems like your suggestion would usually work. Still, behavior of
get/set on this socket option is system dependent. e.g. on Linux see
{{/proc/sys/net/core/wmem_max}} etc.. Going through the system's
setsockopt/getsockopt to unit test hadoop socket option plumbing seems
questionable. I'd suggest removing the tests, but I would be ok with using
your suggestion in a patch that includes a comment that the tests will be
removed if found to still be flaky. I'll attach a v2 patch like that.. Tell me
what you think.
> TestDFSClientSocketSize buffer size tests are flaky
> ---------------------------------------------------
>
> Key: HADOOP-13351
> URL: https://issues.apache.org/jira/browse/HADOOP-13351
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.8.0, 3.0.0-alpha1
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Attachments: HADOOP-13551.001.patch
>
>
> {{TestDFSClientSocketSize}} has two tests that assert that a value that was
> set via {{java.net.Socket#setSendBufferSize}} is equal to the value
> subsequently returned by {{java.net.Socket#getSendBufferSize}}.
> These tests are flaky when we run them. The occasionally fail.
> This is expected behavior, actually, because
> {{Socket#setSendBufferSize()}}[is only a
> hint|https://docs.oracle.com/javase/7/docs/api/java/net/Socket.html#setSendBufferSize(int)].
> (Similar to how the underlying libc {{setsockopt(SO_SNDBUF)}} works).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
