[
https://issues.apache.org/jira/browse/HADOOP-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Fabbri updated HADOOP-13351:
----------------------------------
Attachment: HADOOP-13551.002.patch
Attaching v2 patch. I also noticed and fixed other issues: 1.
testDefaultSendBufferSize() assumes that it is executed first. I believe JUnit
does not guarantee test execution order. I addressed this by always creating a
fresh Configuration in a new {{@Before setUp()}} function.
2. {{tearDown()}} prints a message that it is closing the {{DFSClient}} socket,
but does not close it. I added a {{close()}} there.
> TestDFSClientSocketSize buffer size tests are flaky
> ---------------------------------------------------
>
> Key: HADOOP-13351
> URL: https://issues.apache.org/jira/browse/HADOOP-13351
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.8.0, 3.0.0-alpha1
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Attachments: HADOOP-13551.001.patch, HADOOP-13551.002.patch
>
>
> {{TestDFSClientSocketSize}} has two tests that assert that a value that was
> set via {{java.net.Socket#setSendBufferSize}} is equal to the value
> subsequently returned by {{java.net.Socket#getSendBufferSize}}.
> These tests are flaky when we run them. The occasionally fail.
> This is expected behavior, actually, because
> {{Socket#setSendBufferSize()}}[is only a
> hint|https://docs.oracle.com/javase/7/docs/api/java/net/Socket.html#setSendBufferSize(int)].
> (Similar to how the underlying libc {{setsockopt(SO_SNDBUF)}} works).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
