[ 
https://issues.apache.org/jira/browse/HADOOP-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370528#comment-15370528
 ] 

Hadoop QA commented on HADOOP-12981:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} 
| {color:red} HADOOP-12981 does not apply to trunk. Rebase required? Wrong 
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12796191/HADOOP-12981.001.patch
 |
| JIRA Issue | HADOOP-12981 |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/9954/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Remove/deprecate s3native properties from S3NativeFileSystemConfigKeys and 
> core-default.xml
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12981
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12981
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation, tools
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Minor
>              Labels: aws
>         Attachments: HADOOP-12981.001.patch
>
>
> It seems all properties defined in {{S3NativeFileSystemConfigKeys}} are not 
> used. Those properties are prefixed by {{s3native}}, and the current s3native 
> properties are all prefixed by {{fs.s3n}}, so this is likely not used 
> currently. Additionally, core-default.xml has the description of these unused 
> properties:
> {noformat}
> <!-- s3native File System -->
> <property>
>   <name>s3native.stream-buffer-size</name>
>   <value>4096</value>
>   <description>The size of buffer to stream files.
>   The size of this buffer should probably be a multiple of hardware
>   page size (4096 on Intel x86), and it determines how much data is
>   buffered during read and write operations.</description>
> </property>
> <property>
>   <name>s3native.bytes-per-checksum</name>
>   <value>512</value>
>   <description>The number of bytes per checksum.  Must not be larger than
>   s3native.stream-buffer-size</description>
> </property>
> <property>
>   <name>s3native.client-write-packet-size</name>
>   <value>65536</value>
>   <description>Packet size for clients to write</description>
> </property>
> <property>
>   <name>s3native.blocksize</name>
>   <value>67108864</value>
>   <description>Block size</description>
> </property>
> <property>
>   <name>s3native.replication</name>
>   <value>3</value>
>   <description>Replication factor</description>
> </property>
> {noformat}
> I think they should be removed (or deprecated) to avoid confusion if these 
> properties are defunct.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to